Repository navigation
fix(config-bundle): validate v0 formatted deployed name - #2574
nborges-aws wants to merge 1 commit into
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Focused fix that corrects the config-bundle deployed-name validation to match the v0 physical name format (<project><name>, no separator, no target prefix) and drops the now-unused target lookup from the wizard. The changes are internally consistent:
requireConfigBundleNameFitsis the single source of truth, called from both the imperative handler and the wizard's livenameSchema.- Removing
AddConfigBundleLoader/useProjectTargetsis a clean simplification since the target was never actually part of the deployed name. - Tests cover both the new boundary (100-char accept at
c + 88·x) and the overflow case, and the error-message assertion matches the new format. - Uses the real tmp-project filesystem (
initProject), no excessive mocking; pure validation change, so no new telemetry is warranted.
Nothing blocking. One optional nit for a follow-up: the user-facing help/error text (<project><name>) runs the two names together with no visual separator, which can look like a typo in output like TestProjectc...; consider quoting the name or adding a visual cue, but it's not worth gating merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2574 +/- ##
============================================
- Coverage 97.54% 97.53% -0.01%
============================================
Files 657 657
Lines 48752 48732 -20
============================================
- Hits 47553 47532 -21
- Misses 1199 1200 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
WE don't need this anymore since we are supporting v0 and v1 naming. |
Description
Validate the deployed config bundle name as
<project><bundle>in both the add command and wizard. Also removes deployed target loading from the screen & validation step, as target no longer affects the bundle name. Update wizard help text and 100-character boundary testsType of Change
Testing
How have you tested the change?
bun run test(x pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.