Skip to content

fix(config-bundle): validate v0 formatted deployed name - #2574

Closed
nborges-aws wants to merge 1 commit into
refactorfrom
cb-naming-update
Closed

nborges-aws wants to merge 1 commit into
refactorfrom
cb-naming-update

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

Validate the deployed config bundle name as <project><bundle> in both the add command and wizard. Also removes deployed target loading from the screen & validation step, as target no longer affects the bundle name. Update wizard help text and 100-character boundary tests

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): naming fix

Testing

How have you tested the change?

  • bun run test (x pass, 0 fail)
  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/m PR size: M label Oct 12, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 12, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Oct 12, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Focused fix that corrects the config-bundle deployed-name validation to match the v0 physical name format (<project><name>, no separator, no target prefix) and drops the now-unused target lookup from the wizard. The changes are internally consistent:

  • requireConfigBundleNameFits is the single source of truth, called from both the imperative handler and the wizard's live nameSchema.
  • Removing AddConfigBundleLoader / useProjectTargets is a clean simplification since the target was never actually part of the deployed name.
  • Tests cover both the new boundary (100-char accept at c + 88·x) and the overflow case, and the error-message assertion matches the new format.
  • Uses the real tmp-project filesystem (initProject), no excessive mocking; pure validation change, so no new telemetry is warranted.

Nothing blocking. One optional nit for a follow-up: the user-facing help/error text (<project><name>) runs the two names together with no visual separator, which can look like a typo in output like TestProjectc...; consider quoting the name or adding a visual cue, but it's not worth gating merge.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (437914b) to head (98fac7a).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2574      +/-   ##
============================================
- Coverage     97.54%   97.53%   -0.01%     
============================================
  Files           657      657              
  Lines         48752    48732      -20     
============================================
- Hits          47553    47532      -21     
- Misses         1199     1200       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17

jariy17 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

WE don't need this anymore since we are supporting v0 and v1 naming.

@jariy17 jariy17 closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants