Skip to content

fix(bma): pass the Gateway to BMA as connector_id #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siwachabhi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(bma): pass the Gateway to BMA as connector_id #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions src/assets/__tests__/__snapshots__/assets.snapshot.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4079,8 +4079,9 @@ new session and prints its ID.
uv run client.py --runtime <ACR ARN> --session-id <BMA session ID> --input "List the files in the workspace."
\`\`\`

If you add a Gateway, add \`--gateway <Gateway MCP URL>\` with the URL from the output of \`agentcore deploy\`. BMA adds
the Gateway tools when it creates the session, so the flag has no effect on a session that exists.
If you add a Gateway, add \`--gateway <Gateway ARN>\` with the ARN from the output of \`agentcore deploy\`. Use the
flag only for a new session. The Gateway must support MCP version \`2025-03-26\`. If it does not, the agent gets no Gateway
tools, and BMA does not show an error.

To delete the session after the turn, add \`--delete\`. To print each stream event as JSON, add \`--raw\`.
"
Expand Down Expand Up @@ -4186,7 +4187,7 @@ def main() -> None:
)
parser.add_argument(
"--gateway",
help="The Gateway URL from the output of \`agentcore deploy\`.",
help="The Gateway ARN from the output of \`agentcore deploy\`.",
)
parser.add_argument(
"--role-arn",
Expand Down Expand Up @@ -4240,20 +4241,11 @@ def main() -> None:
"instructions": "Use the available tools to complete the task.",
}
if args.gateway:
# Bedrock Managed Agents calls Gateway with IAM from the service side.
# Bedrock Managed Agents calls Gateway with the session role from the service side.
agent["tools"] = [
{
"type": "mcp",
"server_label": "team_tools",
"required": True,
"connection_origin": "service",
"transport": {"type": "http", "server_url": args.gateway},
}
{"type": "mcp", "server_label": "team_tools", "connector_id": args.gateway}
]
args.input += (
" Then use the Gateway's documentation and runbook tools to explain"
" how to investigate an MCP connection failure. Cite your sources."
)
args.input += " Then list the tools that the Gateway gives you."
events = sessions.create(
agent=agent,
environment={
Expand Down
5 changes: 3 additions & 2 deletions src/assets/python/http/bma/base/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ new session and prints its ID.
uv run client.py --runtime <ACR ARN> --session-id <BMA session ID> --input "List the files in the workspace."
```

If you add a Gateway, add `--gateway <Gateway MCP URL>` with the URL from the output of `agentcore deploy`. BMA adds
the Gateway tools when it creates the session, so the flag has no effect on a session that exists.
If you add a Gateway, add `--gateway <Gateway ARN>` with the ARN from the output of `agentcore deploy`. Use the
flag only for a new session. The Gateway must support MCP version `2025-03-26`. If it does not, the agent gets no Gateway
tools, and BMA does not show an error.

To delete the session after the turn, add `--delete`. To print each stream event as JSON, add `--raw`.
17 changes: 4 additions & 13 deletions src/assets/python/http/bma/base/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def main() -> None:
)
parser.add_argument(
"--gateway",
help="The Gateway URL from the output of `agentcore deploy`.",
help="The Gateway ARN from the output of `agentcore deploy`.",
)
parser.add_argument(
"--role-arn",
Expand Down Expand Up @@ -151,20 +151,11 @@ def main() -> None:
"instructions": "Use the available tools to complete the task.",
}
if args.gateway:
# Bedrock Managed Agents calls Gateway with IAM from the service side.
# Bedrock Managed Agents calls Gateway with the session role from the service side.
agent["tools"] = [
{
"type": "mcp",
"server_label": "team_tools",
"required": True,
"connection_origin": "service",
"transport": {"type": "http", "server_url": args.gateway},
}
{"type": "mcp", "server_label": "team_tools", "connector_id": args.gateway}
]
args.input += (
" Then use the Gateway's documentation and runbook tools to explain"
" how to investigate an MCP connection failure. Cite your sources."
)
args.input += " Then list the tools that the Gateway gives you."
events = sessions.create(
agent=agent,
environment={
Expand Down
Loading