Skip to content

feat(compat): show v0-only resources in project status - #2585

Closed
notgitika wants to merge 8 commits into
aws:refactorfrom
notgitika:feat/v0-status-resources
Closed

notgitika wants to merge 8 commits into
aws:refactorfrom
notgitika:feat/v0-status-resources

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Description

Shows the v0-only resources preserved by #2575 in the v1 status command:

  • datasets
  • A/B tests
  • capacity providers
  • unassigned gateway targets

Dataset, A/B-test, and capacity-provider deployment state comes from the v0 deployed-state.json. Unassigned targets are intentionally shown as local-only because they do not belong to a deployed gateway. Dataset and A/B-test rows open the existing v1 detail screens.

This is intentionally separate from #2575 and depends on it. It does not duplicate #2517: that PR changes the old v0/main status implementation, while this adds support to the refactored v1 project status resolver.

Related Issue

Follow-up to #2575 and the reviewed CLI v0-to-v1 proposal.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • bun test — 4,005 passed
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • bun run secrets:check

Checklist

  • I have read the CONTRIBUTING document
  • I added backend and TUI coverage for the v0-only resources
  • No documentation change is needed beyond the compatibility/migration docs
  • My changes generate no new warnings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gitikavj added 8 commits October 13, 2026 03:13
A frozen copy of aws/agentcore-cli@v0.31.1 src/schema reads unmigrated v0
projects, so anything v0 accepted is still accepted. Lint and Prettier skip
it to keep it diffable against upstream. The schema-audit fixtures cover the
edge cases v0 accepts and v1 doesn't.
projectFormat tells v0 specs (version 1) from v1 ones, and translateV0Spec maps
a parsed v0 spec onto v1's shape: version 2, v0-only collections moved aside,
mcpRuntimeTools renamed to toolRuntimes, artifact renamed to build, and
capacityProviderVolume mounts dropped.
@github-actions github-actions Bot added the size/xl PR size: XL label Oct 13, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 13, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 13, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.31%. Comparing base (609ae00) to head (9178efe).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2585      +/-   ##
============================================
- Coverage     97.50%   96.31%   -1.20%     
============================================
  Files           635      664      +29     
  Lines         47250    50913    +3663     
============================================
+ Hits          46071    49035    +2964     
- Misses         1179     1878     +699     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 13, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 13, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Nice refactor. The v0 compatibility surface is cleanly isolated under src/core/project/legacy/, the vendored schemas sit under src/projectSchemas/v0/ with a byte-identical contract spelled out in README.md, and the test coverage is thorough (translator covers every valid audit fixture, backend resolves v0-only resources, deploy/dev handlers verify delegation and exit-code propagation).

A few things I checked and found fine:

  • withV0Deploy middleware probes isV0Project before withProject tries to parse the v1 schema, so projects whose translation would fail still reach the v0 deployer. Good defensive layering.
  • Test doubles only replace true IO boundaries (V0DeployRunner, ReadWriteJson, HTTP server, filesystem watchers) and use temp directories for real file reads/writes — no excessive mocking.
  • Telemetry: nothing new to instrument here; v0 delegation flows through the existing cli.command_run metric and inherits terminal IO to the subprocess.
  • translate.ts is pure, deep-clones its input, and handles all v0 collection renames/drops documented in the header comment.

Nothing requires changes before merging.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 13, 2026
@notgitika notgitika closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants