Repository navigation
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor #2586 +/- ##
============================================
- Coverage 96.32% 96.31% -0.02%
============================================
Files 671 672 +1
Lines 51273 51528 +255
============================================
+ Hits 49390 49629 +239
- Misses 1883 1899 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice, focused change. The v0-state-first / CFN-outputs-fallback split in projectDevEnvironment, the writer() collision detection, and the entrypoint-based supportsPayments gate are all well tested. A few things I verified while reading, not blocking:
paymentId()insrc/core/project/backends/cdk/devEnvironment.tsmatchescdkId()incdk.ts(both strip_), so CFN output-key lookups likePayment${paymentId(name)}ManagerArnstay in sync with how the stack writes them.resolveDevEnvironmentcorrectly skipsdescribeStackfor v0 projects and for v1 projects without astackReference, so a never-deployed target just returns{}.- The region precedence change in
src/handlers/project/dev/environment.tsis intentional:input.region(from the selected target) now overridesAWS_REGIONfrom.env. Worth flagging in release notes since it's a behavior change for users relying on.envto set region duringdev, but it's consistent with the feature intent. supportsPaymentsonly treats runtimes with a.pyentrypoint (and HTTP/undefined protocol) as payment-capable. TS/JS runtimes silently dropAGENTCORE_PAYMENT_*vars even if payments are declared — the test covers this, and the behavior matches the Python-only payments SDK, but it would be nice to surface a hint to the user when payments are declared but suppressed.
Looks good to merge.
371b5f8 to
0ce88de
Compare
|
Claude Security Review: no high-confidence findings. (run) |
|
to be discussed post release |
Description
Makes
agentcore devpopulate the v0-compatible resource discovery variables for local runtimes:MEMORY_<NAME>_IDAGENTCORE_GATEWAY_<NAME>_URLand_AUTH_TYPEAGENTCORE_PAYMENT_<NAME>_*valuesFor translated v0 projects, values come from the selected target in
agentcore/.cli/deployed-state.json. This includes resources that remain deployed in state after being removed fromagentcore.json, matching v0 behavior. For native v1 projects, values are resolved from the deployed CloudFormation stack outputs.--targetselects the deployment whose resources local dev should use. Without it, the default target or the sole configured target is selected; multiple non-default targets require an explicit choice. The selected target is authoritative forAWS_REGIONandAWS_DEFAULT_REGION.Runtime env declarations are the base, deployed values override them, and
.env.localcan override resource discovery values. Target region remains authoritative. Conflicting resource names that normalize to the same environment key fail instead of selecting an arbitrary value.Inspector mode refreshes deployed resource values on every agent start attempt, matching v0 browser behavior. Concurrent multi-agent starts share one in-flight resolution.
This builds on merged #2575. It uses the naming contract restored by aws/agentcore-l3-cdk-constructs#418 and the generated memory lookup change in #2583 rather than duplicating either. It also implements the
refactorequivalent of #2439; that PR targets the removedsrc/cliarchitecture onmain.Related to #1457.
Intentional differences from v0
Datasets and knowledge bases are not included because v0
agentcore devdoes not export local discovery variables for them.Type of Change
Testing
bun run typecheckbun run lint:checkbun run format:checkbun run buildbun run secrets:checkThe full local suite completed with 4,107 passing and one environment-only failure: the workstation install is missing the optional
@napi-rs/keyringLinux native binding used byscripts/keyring.test.ts. The affected suites pass, and the prior PR revision passed Linux, Windows, macOS, CodeQL, and e2e CI.bun auditreports the repository's existing transitivebraces@3.0.3advisory. This PR does not change dependencies orbun.lock.Checklist
agentcore devcommand referenceBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.