Repository navigation
fix(ci): install every keyring platform binding before the prerelease compile - #2587
Merged
Merged
Conversation
… compile The prerelease workflow compiles all six binary targets but installed only the host platform's @napi-rs/keyring binding, so compile fails on the first non-host target since #2565. Match the release workflow's install step.
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
One-line CI fix that mirrors the existing pattern in release-main-and-preview.yml:79. Verified:
prerelease.ymlrunsbun run compilefor all six targets, so it needs per-target@napi-rs/keyringbindings — hence--os="*" --cpu="*"is required.verify.ymlande2e-test.ymlonly compile the host target, so leaving them on plain--frozen-lockfileis correct and consistent.- The flags match the author's stated local test (lockfile unchanged, all twelve keyring platform packages install).
No code changes, no telemetry surface, no test changes needed. Safe to merge.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2587 +/- ##
=========================================
Coverage 96.32% 96.32%
=========================================
Files 670 670
Lines 51173 51173
=========================================
Hits 49290 49290
Misses 1883 1883 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nborges-aws
approved these changes
Oct 13, 2026
notgitika
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Install all platform bindings for
@napi-rs/keyringin the prerelease workflow, matching release-main-and-preview.yml.Why
#2565 made
compilerequire the per-target keyring binding. The prerelease workflow compiles all six targets but still ran a host-onlybun install, so everyrefactorpush since 8f38d29 fails atcompile:darwin-x64with "Missing keyring binding for bun-darwin-x64" (run). verify.yml compiles only the host target, so it is unaffected.How tested
Ran
bun install --frozen-lockfile --os="*" --cpu="*"locally: all twelve@napi-rs/keyring-*packages install andbun.lockis unchanged. The prerelease workflow will run on this change once merged.