Update GMC Proliferation Module - #219
Merged
Merged
Conversation
Jannetty
requested review from
a team,
afu5,
allison-li-1016,
cainja,
jacob-evarts,
jessicasyu,
kristaphommatha and
pohaoc2
and removed request for
a team
April 12, 2026 05:49
Jannetty
marked this pull request as ready for review
April 12, 2026 05:50
Contributor
|
Finished my first pass of reviews - overall looks good but I have a couple of discussion points/questions to be resolved before approving |
…ty population now falls back to basal growth rate. Flattens nested frowth rate conditional into else-if chain.
… needed for ABM-like growth)
kristaphommatha
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just one quick question about one of the changes 😺
allison-li-1016
approved these changes
Aug 19, 2026
allison-li-1016
left a comment
Contributor
There was a problem hiding this comment.
unit tests passed on my end and I ran the model and verified that the sensitivity param is ignored when the boolean is 0. My comments are pretty minor across the board so this looks good to me
kristaphommatha
approved these changes
Aug 20, 2026
kristaphommatha
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for answering my questions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated time to review: Medium
Summary of changes:
In general this PR adds volume-sensitive growth for the fly GMC cells (which the Neuroblasts will also use)
Add framework for simulating PDE-like growth where cell growth rate is regulated by average cell volumeI REMOVED THIS THIS IS NO LONGER IN THIS PRHow to verify changes:
Here is a minimal GMC setup file:
You can add/adjust the following parameters and run simulations:
Dynamic growth rate volume is a boolean you can turn on and off. When on (1) small cells grow slower than big cells.
Growth rate volume sensitivity is the exponent that determines the slope of the sigmoid (essentially the hill coefficient) dictating how sensitive the growth rate is to the cell's volume.
PDELIKE is a boolean that, when on, makes the cell growth rate a function of the average GMC volume across all GMCs in the simulation.