Wrote two Collection-related utility functions - #234
Open
navyacodes wants to merge 8 commits into
Open
Conversation
navyacodes
marked this pull request as ready for review
August 10, 2026 20:27
navyacodes
added
priority: medium
navyacodes
requested review from
a team,
Jannetty,
allison-li-1016,
cainja,
jacob-evarts,
jessicasyu,
kristaphommatha and
pohaoc2
and removed request for
a team
August 10, 2026 20:27
allison-li-1016
requested changes
Aug 24, 2026
allison-li-1016
left a comment
allison-li-1016
left a comment
Contributor
There was a problem hiding this comment.
Everything else looks good to me -- maybe just consider the comment about forcing the denominator collection to be the longer one
kristaphommatha
requested changes
Aug 24, 2026
…rameter names to be in logical order (numerator, then denominator)
allison-li-1016
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated time to review: small
Description of changes:
collectionFractionwhich compares the fraction of elements in one Collection to anotherasCollectionwhich converts Bags to CollectionsBrief justification of changes:
When a stem cell divides, we need to determine what fraction of the apical and basal voxel sets each daughter cell inherits, since this determines how much Deadpan/Prospero each daughter gets.
collectionFractionprovides a way to compute the overlap fraction between two Collection objects, andasCollectionsupports this by converting Bags to Collection objects.