Skip to content

fix(profiler): link BAMPerfProfiler with 16 KB max page size #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashankm03 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(profiler): link BAMPerfProfiler with 16 KB max page size #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/platforms/android/cpp-profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@ project(android-cmake-flashlight)
set(CMAKE_CXX_STANDARD 17)

add_executable(BAMPerfProfiler src/main.cpp src/atrace.cpp src/utils.cpp)

# Android 15+ devices can use 16 KB memory pages; a binary whose LOAD segments are only 4 KB-aligned
# segfaults there. NDK r28+ does this by default, this keeps older NDKs working too.
target_link_options(BAMPerfProfiler PRIVATE -Wl,-z,max-page-size=16384)
Binary file modified packages/platforms/android/cpp-profiler/bin/BAMPerfProfiler-arm64-v8a
View file
Open in desktop
Binary file not shown.
Binary file modified packages/platforms/android/cpp-profiler/bin/BAMPerfProfiler-armeabi-v7a
View file
Open in desktop
Binary file not shown.
Binary file modified packages/platforms/android/cpp-profiler/bin/BAMPerfProfiler-x86
View file
Open in desktop
Binary file not shown.
Binary file modified packages/platforms/android/cpp-profiler/bin/BAMPerfProfiler-x86_64
View file
Open in desktop
Binary file not shown.