Add possibility to lock all Roots for Overlay usage

[aleksandrsakov]

When i create a modal and use Overlay with locker, it locks only 1 parent Root, so if I have some modal which should be presented on all screens (like network error modal) I can not use Overlay on App.tsx because all child components have their own Root and it doesn't lock

import { useCallback, useEffect } from 'react'
import { useLockSpatialNavigation } from 'react-tv-space-navigation'

import { useGoBack } from '@/app/navigation/hooks'

interface UseLockProps {
  isOverlayVisible: boolean
  hideOverlay: () => void
}

export const useLockOverlay = ({ isOverlayVisible, hideOverlay }: UseLockProps) => {
  useLockParentSpatialNavigator(isOverlayVisible)
  usePreventNavigationGoBack(isOverlayVisible, hideOverlay)
}

const useLockParentSpatialNavigator = (isOverlayVisible: boolean) => {
  const { lock, unlock } = useLockSpatialNavigation()
  useEffect(() => {
    if (isOverlayVisible) {
      lock()
      return () => {
        unlock()
      }
    }
  }, [isOverlayVisible, lock, unlock])
}

const usePreventNavigationGoBack = (isOverlayVisible: boolean, hideOverlay: () => void) => {
  const hideOverlayListener = useCallback(() => {
    if (isOverlayVisible) {
      hideOverlay()
      return true
    }
    return false
  }, [isOverlayVisible, hideOverlay])
  useGoBack(hideOverlayListener)
}

// Overlay.tsx
export const Overlay = ({ children }: OverlayProps) => {
  return (
    <Portal>
      <View style={styles.container}>
        <SpatialNavigationRoot>{children}</SpatialNavigationRoot>
      </View>
    </Portal>
  )
}

// Modal.tsx
export const Modal = ({ isModalVisible, hideModal, children }: Props) => {
  useLockOverlay({ isOverlayVisible: isModalVisible, hideOverlay: hideModal })

  return (
    <Overlay>
      {children}
    </Overlay>
  )
}

// RootStack.tsx
export function RootStack() {
  const { isNetworkModalVisible, setIsNetworkModalVisible } = useNetworkConnection()

  return (
    <SpatialNavigationRoot>
      <Stack.Navigator
        screenOptions={{
          headerShown: false,
        }}
      >
            <Stack.Screen name={ScreenNames.TabBarScreen} component={TabNavigator} />
            // something else
      </Stack.Navigator>

      <NetworkErrorModal
        isModalVisible={isNetworkModalVisible}
        hideModal={() => setIsNetworkModalVisible(false)}
      />
    </SpatialNavigationRoot>
  )
}

It lock navigation only for parent SpatialNavigationRoot but all SpatialNavigationRoot inside TabNavigator screens doesn't lock and navigation works above Modal

How can we manage such situation? Maybe it is possible to create locker for all Roots and navigate only inside Overlay?

[jonp-iversoft]

we got around that by adding a ScreenWrapper component to all our screens that uses global state (jotai atoms in our case) to toggle isActive on the SpatialNavigationRoot in the ScreenWrapper. This disables any active screen if a flyout or overlay is active based on it's state.

not the full component, but gives you the idea:

  const route = useRoute();
  const isExitPromptVisible = useAtomValue(exitPromptAtom);
  const isErrorScreenOpen = useAtomValue(isErrorScreenOpenSelector);

  const isActive = useMemo(
    () =>
      route.name === screenId && // screenId is a prop
      !isExitPromptVisible &&
      !isErrorScreenOpen,
    [
      route.name,
      screenId,
      isExitPromptVisible,
      isErrorScreenOpen,
    ],
  );

return ( <SpatialNavigationRoot isActive={isActive}>{children}</SpatialNavigationRoot> )

[aleksandrsakov]

@jonp-iversoft Thanks for a response, yes I also made it like this, but I have a lot renders of ErrorModal in one page and it is not lock listeners, so I caution a lot of rerenders

[AlecColas]

Hi @aleksandrsakov,

I did not understand your last comment
Did you manage to make it work with the solution proposed by @jonp-iversoft ?

[aleksandrsakov]

@AlecColas yes i do, but with this solution we render a lot of ErrorModal on one page, because react native doesn't unmount components, so i have ScreenWrapper on home page and for example on Details page and they both render ErrorModal one above another