You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It makes sense but I'm not sure there is that much added value: the calculation is very simple and is present only once in the codebase, in a separate place 😁
I'm not sure we need to add a dependency for that!
Maybe there are additional features that I missed?
Would be nice to define it at runtime but I'm not sure components would re-render, since this is computed at root level.
Agree that adding a dependency for this is an overkill. I found that testing on Fire TV/Android TV emulator/Web was giving me some issue with the UI not following the same proportions. I have tested with the react-native-pixel-perfect and all was fixed. I think their formula maybe is more completed as taking as variable also the height.
Let me get back with more testing and some screenshots 🙏 probably we can just modify the calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found the using react-native-pixel-perfect makes it easier to adapt the scaling factor across different screens.
The library is considering width and height that can be defined by the developers or runtime.
Tested on Android TV, Fire TV, tvOS and web.
Check if it makes sense! Thank you!