Skip to content

Correct three figures in the client layout screen, and make layout.py stop the server on a missing ready line or a signal. - #67

Merged
ioquatix merged 3 commits into
mainfrom
hello-layout-review-followup
Nov 9, 2026
Merged

ioquatix merged 3 commits into
mainfrom
hello-layout-review-followup

Conversation

@ioquatix

@ioquatix ioquatix commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Correct three figures from #66 that an independent review found overstated or misattributed, checked against samples.csv, and make the screen's layout.py unable to leave a server running.

  • Layout A in raw-closed was below two workers in every round, but by 5.3% and 5.8% at the median and 3.5–6.7% in single rounds, not 5–6% in every round.
  • "B-u was within 1.1% of B" was the gap between the two "vs C" columns. By the median of each round's ratio, B-u was within 0.3% of B except for hyper-tokio in http-closed, at +2.1% (+1.6% between medians).
  • hana's host document: the worst single round was 8.9% below its cohort's median (base-native, A, server CPUs 2,3), so up to 9%, not 8%.

layout.py sample now gives up if the server prints no address within 60 seconds, which previously held the host lock indefinitely. It also turns SIGHUP, SIGINT and SIGTERM into an exit through its cleanup, because the server and client run in their own sessions and a terminal's signals never reached them. The campaign lets the sample's stderr through so that a failure's reason shows. A successful sample measures and prints the same as before, and no measurements were rerun. The results readme notes that these changes came after the campaigns.

… host document, and make layout.py stop the server on a missing ready line or a signal.
…hat a SIGHUP under nohup no longer aborts a campaign, and name layout C as the reference for layout A's figures in the readme.
@ioquatix
ioquatix merged commit de25645 into main Nov 9, 2026
8 checks passed
@ioquatix
ioquatix deleted the hello-layout-review-followup branch November 9, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant