Repository navigation
Correct three figures in the client layout screen, and make layout.py stop the server on a missing ready line or a signal. - #67
Merged
Conversation
… host document, and make layout.py stop the server on a missing ready line or a signal.
…hat a SIGHUP under nohup no longer aborts a campaign, and name layout C as the reference for layout A's figures in the readme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct three figures from #66 that an independent review found overstated or misattributed, checked against
samples.csv, and make the screen'slayout.pyunable to leave a server running.raw-closedwas below two workers in every round, but by 5.3% and 5.8% at the median and 3.5–6.7% in single rounds, not 5–6% in every round.http-closed, at +2.1% (+1.6% between medians).layout.py samplenow gives up if the server prints no address within 60 seconds, which previously held the host lock indefinitely. It also turnsSIGHUP,SIGINTandSIGTERMinto an exit through its cleanup, because the server and client run in their own sessions and a terminal's signals never reached them. The campaign lets the sample's stderr through so that a failure's reason shows. A successful sample measures and prints the same as before, and no measurements were rerun. The results readme notes that these changes came after the campaigns.