backport(smoke): update AbiDecodeFailed shape and drop stale burnBlocked ABI fragment - #227
Merged
Merged
Conversation
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
September 17, 2026 13:58
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: all 725 passedbase/base is fully in sync with the base-std spec. |
…BI fragment (#226) AbiDecodeFailed reverts now carry a bare function selector with no message, so the harness's length check and docs were tightened to match. Separately, PR #193 restored burnBlocked to the IB20 interface after #186 removed it, so the stablecoin journey's hand-built ABI fragment for it now collides with the real entry under a stricter web3.py ABI validator; call it directly through the normal token binding instead. Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit f39eea1)
rayyan224
force-pushed
the
backport/v1.1.x-smoke-fixes
branch
from
September 17, 2026 14:37
55605b1 to
7558493
Compare
1 task
stephancill
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #226 onto
releases/v1.1.x(Cobalt / v1.1.0).AbiDecodeFailedreverts now carry a bare function selector with no message; relaxedchain.py's length check (and docs) from requiring> 4bytes to>= 4bytes so thefactoryandinvariantsjourneys stop failing on this expected shape change. The selector-match check (which actually verifies the error type) is unchanged._BURN_BLOCKED_FRAGMENT/_burn_blocked_atworkaround instablecoin_lifecycle.py. It duplicated an ABI entry that PR refactor(b20): seizeWithMemo returns void; keep deprecated burnBlocked in IB20 #193 restored toIB20, which a stricter web3.py now raises as a colliding-selectorWeb3ValueErroron contract construction. Both call sites now bind through the normaltokcontract object.Cherry-picked cleanly from
0b28c64(no conflicts).Test plan
PYTHONPATH=script python -m smoke factory -k— passesPYTHONPATH=script python -m smoke invariants -k— passesPYTHONPATH=script python -m smoke stablecoin -k— passesmake smoke KEEP_GOING=1(full suite) — 7 passed, 0 failed, 0 skipped