Skip to content

Reject unsupported PolarShellDistribution dimensions - #562

Open
BJMCox wants to merge 1 commit into
mainfrom
fix-554-polar-shell-dimensions
Open

Reject unsupported PolarShellDistribution dimensions#562
BJMCox wants to merge 1 commit into
mainfrom
fix-554-polar-shell-dimensions

Conversation

@BJMCox

@BJMCox BJMCox commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixes #554.

Validate that the base distribution is two-dimensional at construction. Previously accepted 1D and 3D inputs now fail early with ArgumentError.

Main code: +2/-0.

@BJMCox BJMCox self-assigned this Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.45%. Comparing base (6e8795f) to head (25d41cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files         121      121           
  Lines        7060     7061    +1     
=======================================
+ Hits         4621     4622    +1     
  Misses       2439     2439           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BJMCox
BJMCox force-pushed the fix-554-polar-shell-dimensions branch from d722d95 to 61b2851 Compare August 31, 2026 15:19
@BJMCox
BJMCox force-pushed the fix-554-polar-shell-dimensions branch from 61b2851 to 25d41cd Compare September 1, 2026 12:06
@BJMCox
BJMCox marked this pull request as ready for review September 1, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject non-two-dimensional PolarShellDistribution bases

1 participant