Register a FileValue dep on bzlCompileCache hits in BzlLoadFunction - #30902
Open
fmeum wants to merge 1 commit into
Open
Register a FileValue dep on bzlCompileCache hits in BzlLoadFunction#30902fmeum wants to merge 1 commit into
fmeum wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fmeum
force-pushed
the
claude/bazel-issue-30900-gtza50
branch
from
August 27, 2026 20:52
3df84f2 to
4923d2e
Compare
|
✅ Bazel docs preview is ready! Preview URL: https://bazel-pr-30902.mintlify.app/ Updated for |
The KeyForBuild and KeyForBzlmod variants of a BzlLoadValue key for the same .bzl file share a single BzlCompileValue.Key, and thus a single entry in the bzlCompileCache used when BzlCompileFunction is inlined. When a BzlLoadValue node got a cache hit for an entry that was computed on behalf of a node of the other key variant, it never requested the FileValue for the .bzl file, so it was missing the Skyframe edge that would invalidate it when the file changes and kept serving stale file contents on subsequent builds. Fix this by (re-)requesting the FileValue for the .bzl file on a cache hit. For a cache hit caused by a Skyframe restart of the same node, the dep is already registered and the request is cheap. Fixes bazelbuild#30900.
fmeum
force-pushed
the
claude/bazel-issue-30900-gtza50
branch
from
August 27, 2026 21:32
4923d2e to
9535148
Compare
fmeum
marked this pull request as ready for review
August 27, 2026 21:44
Collaborator
Author
|
@bazel-io fork 9.3.0 |
github-actions
Bot
added
team-Core
Contributor
|
Very nice test case! I'd like a review from @brandjon who has much more historical context about inlined vs. non-inlined compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The KeyForBuild and KeyForBzlmod variants of a BzlLoadValue key for the same .bzl file share a single BzlCompileValue.Key, and thus a single entry in the bzlCompileCache used when BzlCompileFunction is inlined. When a BzlLoadValue node got a cache hit for an entry that was computed on behalf of a node of the other key variant, it never requested the FileValue for the .bzl file, so it was missing the Skyframe edge that would invalidate it when the file changes and kept serving stale file contents on subsequent builds.
Fix this by (re-)requesting the FileValue for the .bzl file on a cache hit.
Motivation
Fixes #30900
Build API Changes
No
Checklist
Release Notes
RELNOTES: None