#1927 - Add redis connect timeout - #6486
Merged
Merged
Conversation
tiago-graf
marked this pull request as ready for review
August 19, 2026 19:24
tiago-graf
enabled auto-merge
August 19, 2026 19:25
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
Collaborator
There was a problem hiding this comment.
Nice findings related to the enableOfflineQueue.
I did not follow if not having the REDIS_ENABLE_OFFLINE_QUEUE exposed was planned or a gap, but I would stringly recommending having it exposed in the CI/CD to allow it to be changed.
weskubo-cgi
disabled auto-merge
August 20, 2026 22:39
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Aug 21, 2026
| - name: FORMS_URL | ||
| required: true | ||
| - name: REDIS_ENABLE_OFFLINE_QUEUE | ||
| value: "false" |
dheepak-aot
approved these changes
Aug 21, 2026
dheepak-aot
left a comment
dheepak-aot
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking up the PR and making changes. Looks good 👍
uhelm
self-requested a review
August 21, 2026 19:54
uhelm
approved these changes
Aug 21, 2026
uhelm
left a comment
uhelm
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Will do some tests once it is deployed to dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce Redis connection timeout to avoid connectivity hanging when service is down.
Disable Offline queue, making the application to not wait when redis is down and move on to database instead.
Update e2e tests to have only API use the ORM cache.