Handle ECDSA algorithm alternate name from parseKeyPair - #81
Merged
Conversation
Owner
|
Perhaps related to #78 ? |
Contributor
Author
Possibly - I have asked him to test with the CI build for this PR. |
|
Thanks @TheFreeman193 - as I've mentioned in my original issue that PR fixed it all 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After observing the behaviour where the RSA chain is selected despite requesting an ECDSA cert, I added some logging lines to follow the algorithm naming from the XML keybox parsing in KeyBoxUtils.kt.
This revealed that
CertificateUtils.parseKeyPair()returns ECDSA in some cases, not EC.This change therefore adds a
whenclause to cover this possibility.After building locally with Android Studio and testing on devices running LineageOS 22.2/A15 and 23.2/A16, I'm now seeing the correct chains when RSA is toggled on/off in Key Attestation Demo.
Closes #78