Validate special characters in app_name config - #3042
Closed
amikal04 wants to merge 1 commit into
Closed
Conversation
Member
|
I'm closing this on the basis that it is unclear why this is needed. There's no issue number associated with the PR, and no explanation why this hardening is required - or why it does anything at all. The 4 provided test cases all behave correctly with the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implemented additional input validation in
is_valid_app_nameto reject app names containing invalid special characters (!@#$%^&*()etc.). Added corresponding unit tests intest_is_valid_app_name.pyto ensure invalid names fail as expected.PR Checklist:
Assisted-by: Gemini