Support gungraun json format

[gamma0987]

This PR adds a gungraun JSON v6 adapter to complement the existing text-based gungraun parser, enabling users to consume machine-readable output directly.

What changed:

• Fixes the missing DHAT metrics also for the text-based gungraun parser in rust/gungraun.rs.
• New AdapterRustGungraunJson in lib/bencher_adapter/src/adapters/rust/gungraun_json.rs
• Uses gungraun-summary to parse the JSON format. These are the types directly exported from gungraun. This eliminates the error source and additional work parsing the JSON manually in bencher.
• Uses gungraun_summary::util::parse_slice() for version-aware parsing (only v6 currently)
• Parses NDJSON input: one benchmark summary per line. This is the default gungraun JSON format. gungraun can print in pretty JSON, but parsing that format is not covered in this pr.
• Supports all 8 Gungraun tools with complete metric coverage. 2 tools (Massif and BBV) don't produce metrics and return an empty vector of GungraunMeasure(s). Massif and BBV return empty benchmark vectors, which afaik surface in the UI with a warning if they are the only tools.
• Rejects Mean/Median averaging like the text-based gungraun parser
• Registers a new rust_gungraun_json adapter in addition to the existing rust_gungraun adapter

Documentation updates are intentionally deferred to a follow-up PR.

Note on benchmark naming and ids:
Already discussed in #778. This parser implementation uses (file::group::function + ::id) and the optional id as benchmark name to identify gungraun benchmarks uniquely. In addition to #778, I want to add that the main problem is that text parsed benchmark names include the "most likely" truncated BenchmarkSummary::details. Exactly replicating the text parsed benchmark name is impossible because the user can disable or change the truncation length with configuration values. The JSON summary doesn't reflect that decision and doesn't store the user provided truncation configuration value. Required follow-up PR: A database migration to convert the old benchmark names to the new ones. Changing the old names to the new names is straightforward but irreversible although I don't think there's any need to go back.

Closes #638

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cargo/​gungraun@​0.18.0 ⏵ 0.19.4	+5
	cargo/​gungraun-summary@​6.0.0

View full report

[github-actions]

Bencher Report

Project	Bencher
Branch	support-gungraun-json-format
Testbed	intel-v1

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
Adapter::Json	📈 view plot 🚷 view threshold	4.66 µs (-0.53%) Baseline: 4.68 µs	5.00 µs (93.17%)
Adapter::Magic (JSON)	📈 view plot 🚷 view threshold	4.59 µs (+1.10%) Baseline: 4.54 µs	4.81 µs (95.52%)
Adapter::Magic (Rust)	📈 view plot 🚷 view threshold	25.74 µs (+0.01%) Baseline: 25.74 µs	26.98 µs (95.40%)
Adapter::Rust	📈 view plot 🚷 view threshold	3.52 µs (-0.28%) Baseline: 3.53 µs	3.93 µs (89.59%)
Adapter::RustBench	📈 view plot 🚷 view threshold	3.52 µs (-0.35%) Baseline: 3.53 µs	3.93 µs (89.44%)

🐰 View full continuous benchmarking report in Bencher

[epompeii]

@gamma0987 thank you for the contribution!

I'm thinking we should extend the existing tree structure of the adapters:

1. rust_gungraun_json is your new JSON adapter
2. rust_gungraun_stdout is the existing nom parser
3. rust_gungraun is now a parent node that attempts to parse JSON then stdout

This will be another level in the tree below: magic -> rust -> rust_gungraun.

[gamma0987]

Sure. No problem

[gamma0987]

What changed (CLI):

• rust/gungraun.rs is now just a dispatcher that tries gungraun_json::AdapterRustGungraunJson::parse then falls back to gungraun_stdout::AdapterRustGungraunStdout::parse.
• Bugfix in the same file: from_sql was missing for RUST_GUNGRAUN_JSON_INT in the prior push.

UI:

• Removed stale Adapter.RustIaiCallgrind references
• Added RustGungraun, RustGungraunJson, RustGungraunStdout to output surfaces (icon, command, ...)
• Fixed gungraun.astro Learn More href.

[epompeii]

Thank you for the updates @gamma0987.
Main question is on the --output-format support.

[epompeii]

Pedantic but lets have stdout be first and json be second here. stdout is the default so IMO it make sense to list if first here and everywhere (other than the actual rust_gungraun parsing, that is).

[epompeii]

It seems like we are supporting the --output-format option set to json but not pretty-json?
Would it be worth going ahead and covering both of them with the rust_gungraun_json adapter? I can see this being a footgun for Bencher users where they also want a somewhat human readable JSON output in a file that they then pass to bencher.