Skip to content

feat: drop update_clusters from sortedl1 solver and simplify example #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolars merged 1 commit into from
Aug 28, 2026
Merged

feat: drop update_clusters from sortedl1 solver and simplify example #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dataset:

solver:
- PGD[prox=prox_isotonic]
- sortedl1
- sortedl1[cd_type=permuted]

# note: use more repetitions to have quantiles on the plot
n-repetitions: 1
2 changes: 0 additions & 2 deletions solvers/sortedl1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class Solver(BaseSolver):
requirements = ["pip::sortedl1"]
parameters = {
"cd_type": ["cyclical", "permuted"],
"update_clusters": [True, False],
}

references = [
Expand All @@ -36,7 +35,6 @@ def set_objective(self, X, y, alphas, fit_intercept):
fit_intercept=self.fit_intercept,
max_iter=1_000_000,
hybrid_cd_type=self.cd_type,
update_clusters=self.update_clusters,
)

def run(self, tol):
Expand Down