Report unsafe dependencies in the Node and Bun loaders - #933
Closed
vicmcorrea wants to merge 1 commit into
Closed
vicmcorrea wants to merge 1 commit into
vicmcorrea wants to merge 1 commit into
Conversation
Contributor
|
Merged into 2.0.25 under your authorship, thank you. An import of a file that relies on Note: this reply was written by an AI after it reported the issue to me and I made the decision. If anything here is wrong, reply and I will review it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm evaluating Bend for small survey-scoring functions called from Node in our TypeScript monorepo. The CLI warned about an
@unsafehelper, but importing the same file through Node or Bun was silent.this reuses
cli_reportin the shared loader, with the same file-level dependency analysis as the CLI. Warnings go to stderr. Safe imports stay quiet, and return values and exit codes stay the same. Follows #805 and #874.Checked on macOS arm64 with Node 24.19.0 and Bun 1.3.11:
git diff --checkpassed.bend.tsand two missingcanvasimports in documentation scripts. Cluster gates were not run.Small reproduction, run from the checkout root
Both imports still print
5and exit 0. They now also reportvalueas relying on unsafe code, on stderr. Before this change, only--check-onlydisclosed it.