refactor(comp): share C/JS show_chr and list/tuple brackets - #943
Open
This-Is-NPC wants to merge 2 commits into
Open
This-Is-NPC wants to merge 2 commits into
This-Is-NPC wants to merge 2 commits into
Conversation
SHOW_ESC and SHOW_HEX emit both showers. JS hex-escapes surrogates and code points past U+10FFFF the way C already did.
SHOW_BR emits Con/Nil as [] and Tuple as () for both C and JS, so the bracket map is one table instead of two if-chains.
|
rescuing PR by commenting (github bug hid it temporarily) |
Collaborator
|
While it is nice that we get the shared behaviour I think either hoisting only the part that is shared but keeping the C/JS skeletons there or applying just the C escape logic to JS would be good solutions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bend2/comp.tsonly. Same language, same Base.The C and JS showers repeated char-escape rules and list/tuple brackets.
One table now emits both.
SHOW_ESC/SHOW_HEXemitshow_chr. JS hex-escapes surrogates andcode points past U+10FFFF the way C already did.
SHOW_BRemitsCon/Nilas[]andTupleas().Net is about even (
+39/−37). The point is one readback policy, not fewer lines.