Fix stale C helper calls in the effects guide - #947
Merged
nicolas-abril merged 1 commit intoSep 22, 2026
Merged
Conversation
|
rescuing PR by commenting (github bug hid it temporarily) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C examples for
io_nodeandio_wait_onno longer match the runtime: the former has an extra argument, and the latter omits the deadline. Correct those calls and explain that a zero deadline waits only for descriptor readiness.Validation: reproduced clang's argument-count errors against emitted C, then verified that the corrected calls compile. Also extracted and built the guide's complete Clock example and ran it through the default, emitted JavaScript, and native C paths; all three print the documented numeric result.
git diff --checkpasses. No runtime code changes.