fix(ci): the other two jobs build the CLI without its siblings too - #607
Merged
beyondnetPeru merged 1 commit intoAug 17, 2026
Merged
Conversation
#604 FIXED THE INSTANCE AND LEFT THE CLASS. `v1.3.5` got `build-and-test: success` — the first time that job has ever passed on a tag — and then died in `publish-npm` on the identical error #604 had just fixed one job above: src/app.module.ts(12,29): error TS2307: Cannot find module '@beyondnet/evolith-core-domain/application/sync/sync.service' Three jobs in this workflow run `npm run build` inside `CLI_DIR`. #604 added the workspace build to one of them. Swept against `origin/main` after the fact: build-and-test cli-build@7 workspace-build@3 OK publish-npm cli-build@3 workspace-build@NONE BROKEN package-binaries cli-build@3 workspace-build@NONE BROKEN `package-binaries` had not failed yet only because it is downstream of `publish-npm` and was skipped. It was one merge away from being the sixth tag. The same edit is applied to both — the broken sequence appeared verbatim twice, which is what made it easy to miss and easy to sweep for. After it, every job that builds the CLI builds the workspace first: build-and-test cli@7 ws@3 OK publish-npm cli@4 ws@3 OK package-binaries cli@4 ws@3 OK WHY THIS KEEPS HAPPENING, STATED PLAINLY Four tags have now failed in this workflow for four causes: SBOM exit code, lint debt, and this one twice. Every one of them was invisible until a tag, because `build-and-test`, `publish-npm` and `package-binaries` are all gated on `release_created`, which `release-gate` sets only for `refs/tags/v*`. On a branch push they are SKIPPED and the workflow reports success. The fix for THAT is not in this commit and is the one worth doing next: nothing in this pipeline is exercised until the moment it is load-bearing. Signed-off-by: aarroyo <beyondnet.peru@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): the other two jobs build the CLI without its siblings too
#604 FIXED THE INSTANCE AND LEFT THE CLASS.
v1.3.5gotbuild-and-test: success— the first time that job has ever passed on a tag — andthen died in
publish-npmon the identical error #604 had just fixed one job above:Three jobs in this workflow run
npm run buildinsideCLI_DIR. #604 added the workspacebuild to one of them. Swept against
origin/mainafter the fact:package-binarieshad not failed yet only because it is downstream ofpublish-npmand wasskipped. It was one merge away from being the sixth tag.
The same edit is applied to both — the broken sequence appeared verbatim twice, which is what
made it easy to miss and easy to sweep for. After it, every job that builds the CLI builds the
workspace first:
WHY THIS KEEPS HAPPENING, STATED PLAINLY
Four tags have now failed in this workflow for four causes: SBOM exit code, lint debt, and this
one twice. Every one of them was invisible until a tag, because
build-and-test,publish-npmand
package-binariesare all gated onrelease_created, whichrelease-gatesets only forrefs/tags/v*. On a branch push they are SKIPPED and the workflow reports success.The fix for THAT is not in this commit and is the one worth doing next: nothing in this
pipeline is exercised until the moment it is load-bearing.
🤖 Generated with Claude Code