Add folder-aware Markdown templates - #269
Conversation
Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
There was a problem hiding this comment.
Overview
Folder-aware Markdown templates: cascading templates/ libraries, /template apply with additive front matter + asset materialization/rollback, default-template for new notes, Save as template, and Command-P ordinary-note preference. Specs, desktop IPC, editor host contract, and solid unit coverage match the product plan.
Concerns
- Sibling default normalization only fires on
false → true, so checkingdefault-templatewhen the key was absent (common File Properties path) leaves other library defaults checked.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Reviewed by a Warp Factory agent.
| const next = readDefaultTemplateDirective( | ||
| parseMarkdownFrontMatter(nextContent), | ||
| ); | ||
| return previous === false && next === true; |
There was a problem hiding this comment.
false. Adding/checking default-template with no prior key (null → true) — the usual File Properties path — skips normalizeDefaultTemplateSiblings, so other library defaults stay true.
| return previous === false && next === true; | |
| return previous !== true && next === true; |
Description
Adds visible, cascading templates folders for Markdown notes. Users can apply templates through /template, choose folder defaults for new notes, and save an existing note as a template. File Properties merge additively, template Assets copy with rebased links and rollback safety, and Command-P keeps templates searchable while preferring ordinary notes on ties.
Closes #221
Type of Change
Testing
Manual Testing Details:
Checklist
Known limitations