Add hx-partial tag handling to v2 - #4050
Open
MichaelWest22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a back port of the hx-partial tag into htmx 2. It is a clean simple addition that just adds the parsing and required and a new findAndSwapPartials funciton that runs after processing OOB's. The only other core change is to prevent the main swap if the response is only white space after the new hx-partials are detected as the only swap contents. This leaves OOB behaviour unchanged so there should be no breaking changes. Also adds some new events and support to extend and use hx-xxxx tags via a htmx:processTemplate event.
Corresponding issue:
Testing
Added new tests for hx-partial
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded