docs(adr): replace unstable line anchors and fix slot launcher name

[bioedca]

Summary

• Replaces every unstable line-number anchor in ADR-0065 with the rule or section it names.
• Converts the three-row anchor table into a three-item rule list and records the active-file versus frozen-reference-tree distinction.
• Normalizes all four mirrored status strings to “slot launcher,” including the hand-edited ADR index cells.
• Changes no review requirement or other rule semantics.

The new ADR paragraph required by #453 is:

Line anchors into a file this repository actively edits are therefore dropped from this record:
rule and section names survive ordinary prose movement. This is not a general ban on line anchors;
older records cite the frozen Deep-LASI reference tree, where a stable line number remains
load-bearing evidence.

Linked tracking

• Closes: docs(adr): cite AGENTS.md by rule name, not line number, and fix the slot-launcher naming #453
• Milestone: none / cross-cutting
• FR: n/a
• Risk: low
• Risk rationale: documentation-only citation and terminology repair, constrained to four named ADR/index files
• Final head SHA: b7a5a04727748c3ae15adf9e5318df2a25b8594a
• Codex: clean posted artifact at docs(adr): replace unstable line anchors and fix slot launcher name #463 (comment); provider reviewed b7a5a04727748c3ae15adf9e5318df2a25b8594a and reported no issues
• Codex closing review: n/a — CodeRabbit cap not spent
• Greptile: skipped without a request; the immediate pre-spawn budget read was 28/50 used globally with 22 remaining, but Tether was already at 18/16 of its monthly allocation
• CodeRabbit — the last metered gate: clean provider-posted full-review artifact at docs(adr): replace unstable line anchors and fix slot launcher name #463 (comment); it reports “No actionable comments were generated,” names the reviewed range ending at b7a5a04727748c3ae15adf9e5318df2a25b8594a, and created no review threads
• Provider that did not review: none
• Findings: 0 actionable from the completed Codex and CodeRabbit legs; CodeRabbit also reported that clone-backed analysis was skipped, while its patch review selected all four changed files; 0 review threads and 0 findings outstanding
• Human sign-off: n/a — this PR introduces no new scientific claim or citation
• Swarm science route: docs/adr/** is science-material by path; after the hosted review lane is complete, this lane stops gate-pending for the dispatcher rather than arming merge itself

Type of change

• docs
• feat
• fix
• ! / BREAKING CHANGE:

Self-review checklist

• Schema freeze respected; no schema files changed.
• Dependency locks unchanged.
• Existing focused ADR-index tests cover cross-links and curated-record equality; both pass.
• Docs updated and mkdocs build --strict passes.
• No data, fixtures, secrets, credentials, private paths, or new files added.
• Pre-commit, including REUSE and secret/large-file guards, passes.
• Hosted review complete — Codex and CodeRabbit are clean on the exact final head.
• Provenance, tunables, GUI coverage, and scientific-citation checks are not applicable to this documentation-only repair.
• The accepted ADR wording is repaired without changing the settled decision.

Testing

• Issue predicates: anchor count 0; context-table header count 0; Deep-LASI count 1; old launcher phrase count 0; slot-launcher phrase count 5; ADR 0057/0064 derived-vs-curated status equality [True, True].
• /opt/homebrew/bin/python3 scripts/gen_adr_index.py --check — passed (63 records).
• pytest tests/test_adr_index.py::test_all_adr_cross_links_resolve tests/test_adr_index.py::test_the_committed_index_matches_the_records — 2 passed.
• pre-commit run --all-files — passed.
• QT_QPA_PLATFORM=offscreen pytest -m "not large and not sidecar and not deep" — 2960 passed, 18 skipped, 34 deselected.
• mkdocs build --strict — passed with the pinned docs toolchain.
• Schema check: not applicable; no schema changes.

Lane state

Hosted review is complete on b7a5a04727748c3ae15adf9e5318df2a25b8594a: Codex is clean on that exact head, Greptile was skipped without a request because Tether is over its monthly allocation, and CodeRabbit’s completed full-review artifact reports no actionable comments on the same head. All required checks are green, origin/main remains 4e61ad11aa44e1348188eeb2f36879d9b2b4f738, and no review thread is outstanding. This docs/adr/** diff is science-material by path, so the worker lane stops gate-pending for the science-gate dispatcher; merge is not armed here.

Summary by CodeRabbit

• Documentation
  • Clarified architecture decision records to identify superseded coordination components more precisely.
  • Replaced fragile line-specific references with stable section names and explanatory descriptions.
  • Documented guidance for avoiding line anchors in actively edited files while retaining them for stable references.
  • Updated the ADR index to reflect the revised terminology.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2357695f-1a4a-4bba-91fd-a488548aa0fa

📥 Commits

Reviewing files that changed from the base of the PR and between 4e61ad1 and b7a5a04.

📒 Files selected for processing (4)

• docs/adr/0057-github-native-swarm-coordination.md
• docs/adr/0064-the-agent-layer-coordinates-writers-not-reviews.md
• docs/adr/0065-a-spent-metered-cap-closes-on-the-unmetered-provider.md
• docs/adr/README.md

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

---

📝 Walkthrough

Walkthrough

The ADR updates synchronize slot launcher terminology across ADR-0057, ADR-0064, and the index. ADR-0065 replaces mutable line references with stable rule or section names and documents line-anchor usage.

Changes

ADR documentation updates

Layer / File(s)	Summary
Synchronize slot-launcher terminology docs/adr/0057-github-native-swarm-coordination.md, docs/adr/0064-the-agent-layer-coordinates-writers-not-reviews.md, docs/adr/README.md	The ADR statuses and index entries identify the superseded component as the slot launcher.
Clarify ADR-0065 review rules docs/adr/0065-a-spent-metered-cap-closes-on-the-unmetered-provider.md	The document names the superseded review rule and replaces the context table with three prose rule descriptions.
Replace mutable line references docs/adr/0065-a-spent-metered-cap-closes-on-the-unmetered-provider.md	The document uses section and rule names instead of mutable AGENTS.md line references. It defines when line anchors remain valid.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b7a5a

This documentation-only change updates ADR anchors and terminology without changing runtime behavior or review rules. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes satisfy issue #453: ADR-0065 uses stable section or rule references, the context table is replaced, the mutable-file citation policy is documented, launcher terminology is normalized to sl…
Out of Scope Changes check	✅ Passed	The changes remain within issue #453. They affect only the four named ADR documentation files and implement the requested citation, table, explanatory-note, and terminology updates without changing re…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Title check	✅ Passed	The title clearly identifies both primary documentation changes: replacing unstable line anchors and correcting the terminology to “slot launcher.”
Description check	✅ Passed	The description is complete and relevant. It includes the summary, linked issue, risk, review status, change type, checklist, testing details, and lane state. It provides sufficient context for the do…

Full details: Linked Issues check

Explanation

The changes satisfy issue #453: ADR-0065 uses stable section or rule references, the context table is replaced, the mutable-file citation policy is documented, launcher terminology is normalized to slot launcher, mirrored ADR data is synchronized, and the required validation is recorded.

Full details: Out of Scope Changes check

Explanation

The changes remain within issue #453. They affect only the four named ADR documentation files and implement the requested citation, table, explanatory-note, and terminology updates without changing review requirements or rule semantics.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Full details: Description check

Explanation

The description is complete and relevant. It includes the summary, linked issue, risk, review status, change type, checklist, testing details, and lane state. It provides sufficient context for the documentation-only changes.

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

---

_{Comment @coderabbitai help to get the list of available commands.}

[bioedca]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: b7a5a04727

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bioedca]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[bioedcam]

Biophysicist science-gate verdict

SCIENCE-GATE: approve

Head reviewed: b7a5a04727748c3ae15adf9e5318df2a25b8594a (full 40-hex PR head).

Scientific assessment:

1. The exact four-file diff changes only agent-governance ADR prose and its generated index mirror: it replaces fragile line-number anchors into an actively edited rule file with section/rule names, preserves the explicit exception for line references into the frozen Deep-LASI reference tree, and normalizes the historical component name to “slot launcher.” It changes no executable scientific code, algorithm or statistical test, validation oracle, tolerance, reference value, dataset, schema, analysis provenance, or scientific citation. Accordingly, the head introduces no new domain-science claim and does not alter the validity of Tether's existing scientific methods or acceptance criteria.

2. The only science-adjacent effect is improved traceability of computational-process documentation. Primary empirical evidence supports treating transparent, inspectable computational artifacts and procedures as relevant to reproducibility: Stodden, Seiler & Ma obtained artifacts for 44% and reproduced findings for 26% of a random 204-paper sample under an upon-request policy (DOI:10.1073/pnas.1708290115; PMID:29531050), while Breznau et al.'s randomized transparent-versus-opaque reproduction study found substantially better exact numerical reproduction with access to the original study and code and identified procedural variation as a source of error (DOI:10.1098/rsos.241038; PMID:40109936). These papers support the traceability rationale; this PR does not add their claims or citations to repository science documentation.

Retraction/editorial-status check (retrieved 2026-08-28): Consensus full records, PubMed records/search, and Crossref relations were checked for both cited primary studies. Neither record is marked retracted or under an expression of concern; PubMed returned no retraction/expression-of-concern/erratum publication-type match, and Crossref reports no retraction/update relation.

[bioedca]

Merge-block diagnosis (2026-09-05). Every required check is green, there are zero review threads, mergeable is true and auto-merge is armed, yet mergeStateStatus reads BLOCKED. The cause is the head commit's signature: b7a5a04727748c3ae15adf9e5318df2a25b8594a reports verification.verified=false, reason=unsigned, and the main-baseline ruleset carries required_signatures. GitHub names no rule for this state; the same silent block was diagnosed on #200.

The fix is a re-signed commit carrying the identical tree, force-pushed over the branch. AGENTS.md forbids an agent from force-pushing and this session's classifier also refused the local rewrite, so it is a maintainer step (native Git Bash; in WSL the repo config already resolves the key, so drop the -c override):

git fetch origin
git worktree add --detach /c/Users/bioed/AppData/Local/Temp/rs453 origin/agent/issue-453
cd /c/Users/bioed/AppData/Local/Temp/rs453
git -c user.signingkey=C:/Users/bioed/.ssh/id_ed25519_signing.pub commit --amend --no-edit
git log -1 --format='%H %G? %s'                                     # must print G
git diff --quiet b7a5a04727748c3ae15adf9e5318df2a25b8594a HEAD && echo tree-identical
git push --force-with-lease=agent/issue-453:b7a5a04727748c3ae15adf9e5318df2a25b8594a origin HEAD:agent/issue-453

If origin/main has moved by then, add a signed git merge --no-ff origin/main before the push (clean merge = non-material). Because the tree is unchanged, the Codex and CodeRabbit evidence recorded above survives under the non-material rule; the moved head then takes the ordinary Codex close on the new SHA before --match-head-commit is armed. Note the auto-merge already armed here will fire on the re-signed head as soon as CI is green; disable it first (gh pr merge 463 --disable-auto) if the closing read should land before the merge.