[frontend] move password change from profile to security settings by capcom6 · Pull Request #43 · bit-issues/backend

capcom6 · 2026-07-21T00:51:30Z

Summary by CodeRabbit

New Features
- Added a secure “Change Password” section to Settings, including current, new, and confirmation password fields.
- Added password validation, submission progress handling, and success or error notifications.
Improvements
- Simplified the Profile page to focus on account information.
- Moved password management from the Profile page to Settings > Security.

coderabbitai · 2026-07-21T00:51:42Z

Warning

Review limit reached

@capcom6, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c482a6ca-ee6f-473a-af7f-638548086c81

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5f197 and 041e0c4.

📒 Files selected for processing (2)

frontend/src/lib/pages/profile.svelte
frontend/src/lib/pages/settings/security.svelte

📝 Walkthrough

Walkthrough

Password management is moved from the profile page to security settings. The security page adds validation, API submission, feedback, and form controls, while the profile page now displays account information only.

Changes

Password management

Layer / File(s)	Summary
Security password-change flow `frontend/src/lib/pages/settings/security.svelte`	Adds password state, validation, API submission, toast feedback, and a disabled-while-saving form in security settings.
Profile account-only layout `frontend/src/lib/pages/profile.svelte`	Removes password-change imports, handler logic, layout, and form, leaving the account information card.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant SecurityPage
  participant changePasswordApi
  participant Toast
  User->>SecurityPage: Enter password fields and submit
  SecurityPage->>changePasswordApi: Submit password change
  changePasswordApi-->>SecurityPage: Return success or error
  SecurityPage->>Toast: Show feedback
  SecurityPage-->>User: Reset fields or display error

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: moving password change UI and logic from profile to security settings.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-21T00:57:59Z

🤖 Pull request artifacts

Platform	File
🐳 Docker	GitHub Container Registry
🍎 Darwin arm64	backend_Darwin_arm64.tar.gz
🍎 Darwin x86_64	backend_Darwin_x86_64.tar.gz
🐧 Linux arm64	backend_Linux_arm64.tar.gz
🐧 Linux i386	backend_Linux_i386.tar.gz
🐧 Linux x86_64	backend_Linux_x86_64.tar.gz
🪟 Windows arm64	backend_Windows_arm64.zip
🪟 Windows i386	backend_Windows_i386.zip
🪟 Windows x86_64	backend_Windows_x86_64.zip

capcom6 · 2026-07-22T00:29:25Z

@coderabbitai full review

coderabbitai · 2026-07-22T00:29:30Z

✅ Action performed

Full review finished.

Your plan includes PR reviews subject to rate limits. More reviews will be available in 51 minutes.

capcom6 · 2026-07-22T06:30:36Z

@coderabbitai full review

coderabbitai · 2026-07-22T06:30:42Z

✅ Action performed

Full review finished.

Your plan includes PR reviews subject to rate limits. More reviews will be available in 40 minutes.

capcom6 · 2026-07-23T00:10:29Z

@coderabbitai full review

coderabbitai · 2026-07-23T00:10:36Z

✅ Action performed

Full review finished.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 32 minutes.

capcom6 · 2026-07-23T08:45:54Z

@coderabbitai full review

coderabbitai · 2026-07-23T08:46:20Z

✅ Action performed

Full review finished.

coderabbitai

🧹 Nitpick comments (1)

frontend/src/lib/pages/settings/security.svelte (1)

166-198: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add password autofill semantics.

Set autocomplete="current-password" on Line 166 and autocomplete="new-password" on Lines 176 and 189. This makes the relocated flow reliably usable with browser and password-manager autofill.

Proposed change

 <Input
   id="old_password"
   type="password"
+  autocomplete="current-password"
   bind:value={oldPassword}
 />

 <Input
   id="new_password"
   type="password"
+  autocomplete="new-password"
   bind:value={newPassword}
 />

 <Input
   id="confirm_password"
   type="password"
+  autocomplete="new-password"
   bind:value={confirmPassword}
 />

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/src/lib/pages/settings/security.svelte` around lines 166 - 198, Add
password autofill semantics to the password inputs in the security form: set
autocomplete to current-password on the Input bound to oldPassword, and
new-password on the Inputs bound to newPassword and confirmPassword. Preserve
the existing bindings and validation behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@frontend/src/lib/pages/settings/security.svelte`:
- Around line 166-198: Add password autofill semantics to the password inputs in
the security form: set autocomplete to current-password on the Input bound to
oldPassword, and new-password on the Inputs bound to newPassword and
confirmPassword. Preserve the existing bindings and validation behavior.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ff812ef-f38c-46a2-87c8-4a46f29fb437

📥 Commits

Reviewing files that changed from the base of the PR and between a3fdef6 and 9c5f197.

📒 Files selected for processing (2)

frontend/src/lib/pages/profile.svelte
frontend/src/lib/pages/settings/security.svelte

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

capcom6 added 2 commits July 24, 2026 06:39

[frontend] Move password change from profile to security settings

1de4cbc

[frontend] improve autocomplete

041e0c4

capcom6 force-pushed the frontend/move-password-change-to-security branch from 9c5f197 to 041e0c4 Compare July 23, 2026 23:40

Uh oh!

Conversation

capcom6 commented Jul 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Pull request artifacts

Uh oh!

capcom6 commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capcom6 commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capcom6 commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capcom6 commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

capcom6 commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading