Skip to content

Bump actions to their latest versions - #1123

Merged
thunderbiscuit merged 3 commits into
bitcoindevkit:masterfrom
thunderbiscuit:chore/bump-actions
Sep 21, 2026
Merged

thunderbiscuit merged 3 commits into
bitcoindevkit:masterfrom
thunderbiscuit:chore/bump-actions

Conversation

@thunderbiscuit

@thunderbiscuit thunderbiscuit commented Sep 18, 2026

Copy link
Copy Markdown
Member

This is a bump of some of our GitHub actions. I ran into problems with the android-actions/setup-android@v3 on the Devkit Wallet and that prompted me to take a look at our actions here.

  • Commit 1 is bumping actions that don't need anything new.
  • Commit 2 bumps zizmor. We are currently using it the "manual" way, but there is also a GitHub action for it. I just didn't want to mess with it too much here. See the action here
  • Commit 3 bumps the actions-rust-lang/setup-rust-toolchain action. See the bdk_wallet PR for this. This one needed a small fix to keep our current behavior. The v2 version will not fail the runs on compiler warnings, which is what we currently do, unless we bump the compiler version to 1.97 or newer. I prefer to keep that bump to a separate PR just to make sure everything works well for our dependencies and whatnot, so I instead opted to turn on the flag manually. We can revert the rustflags: "-D warnings" lines once we bump the Rust compiler version.

Note that because these changes don't impact any of the Swift/Android/Rust files, the CI workflows don't run automatically. Here are 2 runs, showing green CI:

@thunderbiscuit thunderbiscuit changed the title ci: bump simple actions to their latest versions Bump actions to their latest versions Sep 18, 2026
@thunderbiscuit thunderbiscuit added this to the 3.1.1 milestone Sep 18, 2026
@thunderbiscuit
thunderbiscuit requested a review from reez September 18, 2026 15:45

@ItoroD ItoroD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ACK c5c3ffb

@thunderbiscuit
thunderbiscuit merged commit c5c3ffb into bitcoindevkit:master Sep 21, 2026
6 checks passed
@thunderbiscuit

Copy link
Copy Markdown
Member Author

Related issue is #1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants