Skip to content

refactore(test): ignore slow tests locally during pre-push, still run them in CI - #77

Merged
nymius merged 1 commit into
bitcoindevkit:masterfrom
MusabYK:refactor/optimize-pre-push-tests
Sep 7, 2026
Merged

refactore(test): ignore slow tests locally during pre-push, still run them in CI#77
nymius merged 1 commit into
bitcoindevkit:masterfrom
MusabYK:refactor/optimize-pre-push-tests

Conversation

@MusabYK

@MusabYK MusabYK commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

This is a follow up #75

Notes to the reviewers

I group slow but correct/implemented tests under a nested mod slow { .. } block and add #[ignore]. This excludes them from local cargo test runs (just test/pre-push), but CI targets them all using a single filter: cargo test -- --ignored slow::. slow tests should now be added in mod slow{..} block in any file or crate. Also added just test-slow (alias just ts) and just test-all (alias just ta) since slow tests are still real tests someone may want to run before trusting a change.

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@nymius nymius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6d61ce3

@nymius
nymius merged commit bd43521 into bitcoindevkit:master Sep 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants