fix(electrum): refresh header cache with headers fetched for the chain update - #2320
Open
evanlinjin wants to merge 2 commits into
Open
evanlinjin wants to merge 2 commits into
evanlinjin wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2320 +/- ##
==========================================
+ Coverage 78.84% 78.87% +0.02%
==========================================
Files 31 31
Lines 6060 6072 +12
Branches 288 288
==========================================
+ Hits 4778 4789 +11
- Misses 1203 1204 +1
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…n update `block_header_cache` was only written by `batch_fetch_anchors`, so after a reorg it kept serving the pre-reorg header for that height. The anchor cache is keyed by `(txid, hash)` from that header, so a tx re-mined at the same height hit the anchor cache with the stale hash, skipped proof validation, and was never re-anchored to the replacement block. `fetch_tip_and_latest_blocks` now writes the headers it fetches (the chain suffix and the agreement-walk checkpoints) into the header cache.
Checks the tx is re-anchored to the replacement block both when the reorged height is still in the synced chain suffix and when 20 blocks are mined before the next sync. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
evanlinjin
force-pushed
the
fix/electrum-stale-header-cache-master
branch
from
September 18, 2026 10:14
6444d74 to
6c5e977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward-port of #2319 to
master.block_header_cachewas only written bybatch_fetch_anchors, so after a reorg it kept the pre-reorg header for that height. A tx re-mined at the same height then hit the anchor cache under the stale block hash, skipped proof validation, and was never re-anchored to the replacement block. This happens even for a 1-block reorg.fetch_tip_and_latest_blocksnow writes the headers it fetches (the chain suffix and the agreement-walk checkpoints) into the header cache.Notes to the reviewers
Only differences from #2319: the
fetch_tip_and_latest_blockssignature keeps master'sCheckPoint<BlockHash>, and the test uses master'sTestEnv/LocalChainAPIs. The test fails onmasterwithout the fix.Related: #2312.
Changelog notice
bdk_electrumreturning a stale anchor for a transaction re-mined at the same height after a reorg.Checklists
All Submissions:
Bugfixes:
🤖 Generated with Claude Code