Repository navigation
ci: check no_std and WASM builds, harden workflow - #86
Merged
Merged
Conversation
Add `Check no_std` and `Check WASM` jobs, modelled on bdk_wallet's CI.
The crate is `#![no_std]` with an optional `std` feature, but nothing
previously built it without default features.
Also set `permissions: {}` and `persist-credentials: false` on every
checkout so jobs don't hold a token they never use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
proptest 1.12 depends on rand 0.10, while our `rand` dev-dependency is 0.9, so a fresh resolve (as CI does, `Cargo.lock` isn't committed) fails to build the tests with `TestRng: rand::Rng` not satisfied. This broke the `test` and `clippy_check` jobs on master and every open PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@evanlinjin please rebase and merge when ever you want. I've updated the required checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage 1 of fixing the required status checks on
master, plus a fix for thetestandclippy_checkjobs, which fail onmasterand every open PR (e.g. #84).The
Default Branchruleset requires 14 checks copied from an older bdk_wallet CI (miniscript/no-std,bdk_chain/hashbrown, and so on). Nothing in this repo reports them, so every PR sits on "Expected — waiting for status" indefinitely.This PR ports the bdk_wallet jobs that make sense for this crate:
Check no_std:cargo check --no-default-features. The crate is#![no_std]with an optionalstdfeature, but CI never built it without default features.Check WASM:cargo check --target wasm32-unknown-unknown --no-default-features. The crate is pure Rust, so bdk_wallet's clang setup isn't needed.permissions: {}at the workflow level andpersist-credentials: falseon every checkout.Left out: the ARM runner matrix (little value for integer arithmetic), code coverage (needs a
CODECOV_TOKENsecret) and zizmor.Fix: cap
proptestbelow 1.12proptest 1.12 depends on rand 0.10, but our
randdev-dependency is 0.9.Cargo.lockisn't committed, so CI resolves the newest proptest and the tests fail to build (TestRng: rand::Rngis not satisfied). The dev-dependency is nowproptest = ">=1.7, <1.12". Moving to rand 0.10 and proptest 1.12 together is left for a follow-up, since rand 0.10 deprecatesRngCoreand the tests would need changes. Once this is merged, open PRs need a rebase ontomasterto go green.Follow-up (needs a repo admin)
Replace the ruleset's required checks with the jobs this repo actually runs:
Rustfmt,clippy_check,build-msrv,test,doc-build,Check no_std,Check WASM.Checklists
cargo check --no-default-featuresand the WASM check pass locallycargo fmt,clippy,docandtestpass locally on a fresh resolve (noCargo.lock)🤖 Generated with Claude Code