feat: add frigate electrum based RPC methods - #16
Conversation
sdmg15
changed the title
server.version, blockchain.silentpayments.subscribe and blockchain.silentpayments.unsubscribe
225fc0c to
885cd2f
Compare
|
Thanks for the PR! Note that it needs a rebase now with the recent merges. |
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
In https://github.com/sparrowwallet/frigate#serverfeatures it mentions the new field in server.features, is it not needed by bdk-sp ?
|
@sdmg15 I just thought this now during the call, but you could also try adding support for these in https://github.com/bitcoindevkit/rust-electrum-client, not sure if the architecture there supports it though. |
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks for updating @sdmg15 !
I left a few more comments
|
@noahjoeris Thanks for the reviews. I've applied the changes. |
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks again for updating man. Almost there 🚀
Could you also add doc comments to the pub fields you added?
|
Thanks @sdmg15 . I left some final nits. And I ran a quick manual test and it was looking good. |
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
tACK on the code. Manually tested against Frigate 1.4.1 on regtest with sp txs.
Before merge, please fold the history into:
feat: support attributes in gen_pending_request_types!feat: add Frigate Silent Payments RPC support
Also left some docs update suggestions (non-blocking).
Thanks for all the updates
d93c094 to
7b1017a
Compare
4 participants
This PR adds supports for additional RPC methods provided by Frigate electrum based RPC server.
The added methods are:
server.version: This is the first message sent to establish connection with serverblockchain.silentpayments.subscribe: This takes a spend public key and a scan private key and return outputs belonging to the them.blockchain.silentpayments.unsubscribe: This takes a spend public key and a scan private key and unsubscribe from notifications.Some context:
This is useful for the PR opened at bitcoindevkit/bdk-sp#48 which is doing integration of frigate ephemeral scanning.
Opening this PR in order to receive feedback.
Reference:
https://github.com/sparrowwallet/frigate/
Supported Frigate version 1.3.2