Fix auth integration improvements - #227
Open
dorinengabdoh wants to merge 2 commits into
Open
Conversation
dorinengabdoh
requested review from
luisschwab and
oleonardolima
as code owners
September 5, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the test robustness and resource management for the authenticated electrum integration tests:
Shutdown::Bothcalls on the TCP streams when the proxy terminates to prevent thread and socket leaks.test_auth_with_keycloakso the test skips with an explanatory message instead of panicking on machines without Docker.wait_until_electrum_sees_blocktimeout from 6s to 15s to prevent flaky failures on slower CI runners.