Skip to content

Fix V2 Rest book API return funding result error - #205

Open
fshiori wants to merge 2 commits into
bitfinexcom:masterfrom
fshiori:fix/book
Open

fshiori wants to merge 2 commits into
bitfinexcom:masterfrom
fshiori:fix/book

Conversation

@fshiori

@fshiori fshiori commented Dec 24, 2019

Copy link
Copy Markdown
Contributor

Description:

rest book api return different sort by trading and funding,
and now the SDK only support trading.

Breaking changes:

None

New features:

None

Fixes:

  • NewBookUpdateFromRaw func data comment error
  • process funding symbol corerectly

PR status:

  • Version bumped
  • Change-log updated

@harry830622

Copy link
Copy Markdown

@fshiori Really appreciate the PR, bump into the exact same problem here.
@JacobPlaster Would you please take a look and merge the PR? Or how can I help to merge this PR?
Thanks

Comment thread v2/types.go
}

func IsFunding(symbol string) bool {
return strings.HasPrefix(symbol, "f")

@harry830622 harry830622 Aug 8, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return strings.HasPrefix(symbol, "f")
return strings.HasPrefix(symbol, FundingPrefix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants