Add <profileable> for release startup profiling - #2328
Closed
JohnathanWhite wants to merge 14 commits into
Closed
Conversation
…y-app into release/14.46
…vo/bitpay-app into release/14.46
…bitpay-app into release/14.46
No consumer Android device ships 32-bit-only x86 (the Atom phone line ended in 2016) and Play has required 64-bit since Aug 2019, so the x86 slice is dead weight in every AAB. x86_64 stays for ChromeOS, Intel-Mac emulators, and Play pre-launch test devices. abiFilters lives in defaultConfig because AGP unions buildType ndk.abiFilters with it — a release block can only add ABIs, not remove them.
Lets a shell-initiated profiler (Perfetto / am profile) read the app's own atrace sections on a release build, without making the app debuggable. It is release-safe and has zero steady-state runtime cost — the tag only matters while a trace is actively recording. minSdk is 30, so it is fully supported. On the New Architecture, React Native emits its androidx.tracing sections in release builds, so this exposes framework startup slices (mount items, event emitters, Fabric commits) to a system trace with no other code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.