Deeplinks/Buy/Sell: Ref - Prevent to close webView modal from deeplinks handling - #2339
Merged
JohnathanWhite merged 1 commit intoAug 26, 2026
Conversation
JohnathanWhite
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
APP.inAppBrowserOpenstate in Redux is set to true only whenopenUrlWithInAppBrowser(app.effects.ts:647) opens a real native session. The block in useDeeplinks.ts called InAppBrowser.close() without checking that state—it only checked isAvailable() (whether the module exists on the device, not whether a session is open). On iOS, close() in react-native-inappbrowser-reborn calls RCTPresentedViewController() and dismisses whatever view controller is currently presented; it's not scoped to a specific IAB session. If the WebView modal (used in buy/sell) is presented as a native modal at that moment, it ends up closing that instead of a real IAB.