Repository navigation
test: drop tests that repeat another's code path, cover the untested ones - #27
Merged
Merged
Conversation
…ones Co-Authored-By: LLM <noreply@maxholman.dev>
maxholman
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A coverage audit found tests that exercise the same code as another test and assert the same thing. Most came from running each query style through behaviour that is settled before any style-specific code runs, and from repeating what the serializer tests already show through the client. They made the suite slower to read and hid what each style actually decides. Where a case depends on a style, such as an empty array, where query-string's handling differs by array format, every style keeps its own test.
The same audit found code that no test reached: validation of async schemas and of pending values, the client's custom response validator refusing a body, error details carried over from a response body, a command's JSON and string forms, and a request body sent through the real fetcher. The body test also covers bytes backed by shared memory, which fetch would otherwise send as a comma-separated list of numbers. That test fails if the copy that prevents this is removed.