Skip to content

Fix[ntsa::Event::print]: UB on buffer over-read #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrm456 merged 3 commits into from
Sep 16, 2026
Merged

Fix[ntsa::Event::print]: UB on buffer over-read #402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1182881
Fix[ntsa::Event::print]: UB on buffer over-read
678098 May 14, 2026
1080a2d
Update ntsa_event.cpp
678098 May 14, 2026
9d573e2
Update ntsa_event.cpp
678098 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 15 additions & 50 deletions groups/nts/ntsa/ntsa_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,59 +203,24 @@ bsl::ostream& Event::print(bsl::ostream& stream,
bsl::string stateDescription;
bsl::size_t numFlags = 0;

if ((d_state & (1 << EventType::e_READABLE)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}

stateDescription.append("READABLE", 8);
++numFlags;
}

if ((d_state & (1 << EventType::e_WRITABLE)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}

stateDescription.append("WRITABLE", 8);
++numFlags;
}

if ((d_state & (1 << EventType::e_EXCEPTIONAL)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}

stateDescription.append("EXCEPTIONAL", 11);
++numFlags;
#define NTSA_CHECK_PRINT(FLAG, STR) \
if ((d_state & (1 << (FLAG))) != 0) { \
if (numFlags > 0) { \
stateDescription.append(1, ' '); \
} \
static const bsl::string_view k_DESC = (STR); \
stateDescription.append(k_DESC); \
++numFlags; \
}

if ((d_state & (1 << EventType::e_ERROR)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}
NTSA_CHECK_PRINT(EventType::e_READABLE, "READABLE");
NTSA_CHECK_PRINT(EventType::e_WRITABLE, "WRITABLE");
NTSA_CHECK_PRINT(EventType::e_EXCEPTIONAL, "EXCEPTIONAL");
NTSA_CHECK_PRINT(EventType::e_ERROR, "ERROR");
NTSA_CHECK_PRINT(EventType::e_SHUTDOWN, "SHUTDOWN");
NTSA_CHECK_PRINT(EventType::e_HANGUP, "HANGUP");

stateDescription.append("ERROR", 5);
++numFlags;
}

if ((d_state & (1 << EventType::e_SHUTDOWN)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}

stateDescription.append("SHUTDOWN", 8);
++numFlags;
}

if ((d_state & (1 << EventType::e_HANGUP)) != 0) {
if (numFlags > 0) {
stateDescription.append(1, ' ');
}

stateDescription.append("HANGUP", 12);
Comment thread
mattrm456 marked this conversation as resolved.
++numFlags;
}
#undef NTSA_CHECK_PRINT

printer.printAttribute("state", stateDescription);
}
Expand Down
Loading