Skip to content

CLI: keep transaction CBOR in Yaci Store - #205

Open
satran004 wants to merge 1 commit into
mainfrom
devkit/store-save-cbor
Open

satran004 wants to merge 1 commit into
mainfrom
devkit/store-save-cbor

Conversation

@satran004

@satran004 satran004 commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Sets store.transaction.save-cbor=true in the Yaci Store config that the CLI generates. With it, /api/v1/txs/{hash}/cbor works on devnets.

Why: Yaci Viewer's planned Script Lab (#207) re-runs and debugs script executions in the browser with the julc WebAssembly engine. Replay already works from structured store data. Raw transaction CBOR is what will make it byte-exact (once julc can evaluate from CBOR, bloxbean/julc#244). It also enables "why won't my tx submit?" debugging.

Scope: applies to newly created devnets, because the store config is written when a devnet is created. Storage cost on a devnet is negligible.

Testing: ./gradlew compileJava. Before this change, the devnet store returned 404 "Make sure store.transaction.save-cbor=true is enabled" for /txs/{hash}/cbor.

🤖 Generated with Claude Code

Enables store.transaction.save-cbor so /txs/{hash}/cbor works on devnets. The viewer needs
the raw transaction to replay and debug script executions exactly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copy link
Copy Markdown

Initial automated review · Aster

Hi @satran004, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong.

Reviewed commit: a1a163fb60b901fc2af0411f7383574e5a150c33

Issues found:

  • applications/cli/src/main/java/com/bloxbean/cardano/yacicli/localcluster/yacistore/YaciStoreConfigBuilder.java:83 — The bundled Store 2.0.7 still defaults store.cardano.return-tx-body-cbor to false, so its parser omits body CBOR and TransactionProcessor skips saving it, leaving /txs/{hash}/cbor returning 404. Please enable that flag alongside save-cbor.

Not tested: Build and devnet CBOR retrieval were not run; native-build CI is still in progress.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants