Skip to content

fix(engine): return null from IsHTMLDDA [[Call]] per Annex B §B.3.6.1 #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 1 commit into from
Sep 6, 2026
Merged

fix(engine): return null from IsHTMLDDA [[Call]] per Annex B §B.3.6.1 #5511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/engine/src/builtins/is_html_dda.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use crate::{
/// This is used by the `$262.IsHTMLDDA` test harness object and models the
/// legacy `document.all` behavior per ECMAScript Annex B §B.3.6.
///
/// The object is callable — when called, it returns `undefined`.
/// The object is callable — when called, it returns `null` per ECMAScript Annex B §B.3.6.1.
#[derive(Debug, Clone, Copy, Trace, Finalize)]
#[boa_gc(empty_trace)]
pub struct IsHTMLDDA;
Expand All @@ -44,7 +44,7 @@ impl JsData for IsHTMLDDA {

/// The `[[Call]]` internal method for `IsHTMLDDA` objects.
///
/// When called, simply returns `undefined`.
/// When called, simply returns `null` per ECMAScript Annex B §B.3.6.1.
#[allow(clippy::unnecessary_wraps)]
fn is_html_dda_call(
_obj: &JsObject,
Expand All @@ -59,8 +59,8 @@ fn is_html_dda_call(
let _func = context.vm.stack.pop();
let _this = context.vm.stack.pop();

// Push undefined as the return value.
context.vm.stack.push(JsValue::undefined());
// Push null as the return value.
context.vm.stack.push(JsValue::null());

Ok(CallValue::Complete)
}