Skip to content

Split close-out guidance into shorter paragraphs - #418

Merged
bompus merged 1 commit into
mainfrom
fix/closeout-paragraphs
Oct 22, 2026
Merged

bompus merged 1 commit into
mainfrom
fix/closeout-paragraphs

Conversation

@bompus

@bompus bompus commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Split the 1129-character close-out paragraph into three adjacent paragraphs of 254, 669 and 204 characters. This keeps each below an existing consumer's 1000-character paragraph limit without changing the words, punctuation or order.

No wording or behavior change is intended. The close-out, session-scope and ledger requirements remain identical after whitespace normalization. Only the paragraph breaks and an Unreleased changelog entry change. Host generation and installation are separate.

All README Development checks exited 0 on this exact commit. Node tests reported 183 passed and 7 existing skips; Bun reported 643 passed and 8 existing skips. Skill tests passed 461 cases, packaging verified 235 files, and focused scope checks passed 24 cases. Source comparison proves normalized identity, and portable composition preserves the paragraph breaks. Actual host generation and model behavior equivalence were not tested.

  • The checks in the README's Development section pass.
  • A change users will notice has a CHANGELOG.md entry under Unreleased.
  • Nothing names a private project or repository, a local path, a home directory or a credential.

Summary by cubic

Splits the 1129-character close-out paragraph in rules/core.md into three shorter paragraphs so each stays under an existing consumer's 1000-character limit.

  • The wording, punctuation, and order are unchanged; only the paragraph breaks differ.
  • Adds an Unreleased changelog entry.

Written for commit a6b356b. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Documentation
    • Updated close-out guidance by splitting it into shorter paragraphs for improved readability.
    • Clarified the presentation of instructions covering user-owned deferrals, session close-out behavior, and when to close work rather than defer it.
    • Requirements and behavior remain unchanged.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@bompus

bompus commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a4ea4694-9438-4354-9eba-2267590deca2
📥 Commits

Reviewing files that changed from the base of the PR and between b4429ab and a6b356b.

📒 Files selected for processing: 2
  • CHANGELOG.md
  • rules/core.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Finishing work guidance was split into shorter paragraphs. The Unreleased changelog records the formatting change and states that the requirements did not change.

Changes: Close-out guidance

Layer / File(s) Summary
Reformat finishing-work guidance
rules/core.md, CHANGELOG.md
The Finishing work guidance is split into separate paragraphs. The changelog records the edit and states that requirements remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to a6b35

The change is a documented paragraph reformat with no established behavior or requirement change.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: splitting close-out guidance into shorter paragraphs.
Description check Passed The description explains the change, its purpose, expected behavior, validation results, and changelog entry. It also confirms that the required repository checks passed and that no sensitive project …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Suppressions Explained Passed The pull request changes only CHANGELOG.md and rules/core.md. The added lines split prose into paragraphs and add a changelog entry. No lint, type-check, formatter, or ignore directive was added or br…
Rule Changes Documented Passed rules/core.md changes in the reviewed diff. CHANGELOG.md adds a matching entry under Unreleased: “Split the close-out instructions into shorter paragraphs without changing their requirements.” N…
Full details: Description check

Explanation

The description explains the change, its purpose, expected behavior, validation results, and changelog entry. It also confirms that the required repository checks passed and that no sensitive project information is included.

Full details: Suppressions Explained

Explanation

The pull request changes only CHANGELOG.md and rules/core.md. The added lines split prose into paragraphs and add a changelog entry. No lint, type-check, formatter, or ignore directive was added or broadened.

Full details: Rule Changes Documented

Explanation

rules/core.md changes in the reviewed diff. CHANGELOG.md adds a matching entry under Unreleased: “Split the close-out instructions into shorter paragraphs without changing their requirements.” No modifier or skill was added, removed, or renamed, and README.md does not need a table update.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@bompus

bompus commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

cubic skipped this head because its monthly review limit is exhausted (40,438 of 40,000 lines; resets November 11). Greptile also skipped because its 50-credit trial limit is exhausted. These capacity skips follow the standing review policy. CodeRabbit review and Linux/Windows CI are still running.

@bompus
bompus merged commit a6b356b into main Oct 22, 2026
4 checks passed
@bompus
bompus deleted the fix/closeout-paragraphs branch October 22, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant