Give an overflow the largest finite value in the modes which ask for it - #1460
Merged
Merged
Conversation
ibmibmibm
marked this pull request as ready for review
September 17, 2026 15:54
ibmibmibm
force-pushed
the
overflow-mode
branch
from
September 17, 2026 16:03
85b7944 to
fb001ba
Compare
Contributor
Author
|
It seems that |
Member
Yes. Dec test is hosted separately due to license incompatibility. |
- IEEE 754-2019 7.4: an overflow is the largest finite value in the toward zero mode, and in the directed mode which points at zero for the sign. Every type gave an infinity in every mode. - A new helper reads the mode, and each constructor packs the largest finite value in place of the infinity when the helper says so. - The float constructors of the three IEEE types had their own overflow check, which lost the sign. They now take the same path as the fast types. Fixes boostorg#1459
ibmibmibm
force-pushed
the
overflow-mode
branch
from
September 18, 2026 12:22
fb001ba to
2395df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and in the directed mode which points at zero for the sign. Every type gave an
infinity in every mode.
place of the infinity when the helper says so.
lost the sign. They now take the same path as the fast types.
Fixes #1459