fix: do not create map cells when adding or subtracting zero - #441
Merged
HDembinski merged 1 commit intoJul 30, 2026
Merged
Conversation
map_impl::reference::operator+= and operator-= emplaced a cell for a
missing index even when the result stayed at value_type{}. Compute the
result in a temporary and emplace only if it is non-default, as
operator/= already does.
Assisted-by: ClaudeCode:claude-opus-5
Contributor
Author
|
Update: actually fixing this fully isn't bad at all (compared to trying to patch it downstream in boost-histogram, especially!), so I'm going to make an alternative full-fix PR in a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_impl::reference::operator+=andoperator-=emplaced a cell for a missing index even when the result stayed as defaultvalue_type{}. Compute the result in a temporary and emplace only if it is non-default, asoperator/=already does.First half of #440, the simple fix.
Assisted-by: ClaudeCode:claude-opus-5