Skip to content

fix array end handling for first variant alternative in parse_into #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ramya-9353 wants to merge 3 commits into
base: develop
Choose a base branch
from
+16 −1
Open

fix array end handling for first variant alternative in parse_into #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a730f74
fix array end handling for first variant alternative in parse_into
Ramya-9353 Sep 4, 2026
1a0e3d2
exclude into_handler::signal_end from coverage
Ramya-9353 Sep 18, 2026
bd3af54
use an array sample in the incomplete-alternative test
Ramya-9353 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/boost/json/detail/parse_into.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,7 +1601,7 @@ class converting_handler<variant_conversion_tag, T, P>

bool on_array_end( system::error_code& ec )
{
if( !inner_active_ )
if( inner_active_ < 0 )
return signal_end(ec);

BOOST_JSON_INVOKE_INNER( array_end_handler_event{}, ec );
Expand Down Expand Up @@ -1864,10 +1864,14 @@ class into_handler
return true;
}

// LCOV_EXCL_START
// the top handler is never inside an array, so nested handlers have no
// array end to forward to it
bool signal_end(system::error_code&)
{
return true;
}
// LCOV_EXCL_STOP

bool on_document_begin( system::error_code& )
{
Expand Down
11 changes: 11 additions & 0 deletions test/parse_into.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <boost/json/value_to.hpp>
#include <boost/describe.hpp>

#include <array>
#include <climits>
#include <map>

Expand Down Expand Up @@ -479,6 +480,16 @@ class parse_into_test
testParseInto< std::vector< Variant<int, std::string> > >(
{1, 2, 3, "four", 5, "six", "seven", 8});

// an array-like first alternative nested in a composite
testParseInto< std::vector< Variant<std::vector<int>, int> > >(
{ std::vector<int>{1}, 2 } );
testParseInto< std::map<std::string, Variant<std::vector<int>, int> > >(
{ { "a", std::vector<int>{1, 2} }, { "b", 3 } } );

// an incomplete array must not satisfy a fixed-size alternative
testParseIntoErrors< Variant< std::array<int, 3> > >(
error::exhausted_variants, {1, 2} );

using V = Variant<
std::vector< int >,
std::tuple< int, std::string, std::map<std::string, int> >,
Expand Down
Loading