Skip to content

pass full string_view to enum_from_string in value_to #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grisumbras merged 1 commit into from
Oct 6, 2026
Merged

pass full string_view to enum_from_string in value_to #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/json/detail/value_to.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ value_to_impl(
return {system::in_place_error, ec};
}

if( !describe::enum_from_string(str->data(), val) )
if( !describe::enum_from_string(str->subview(), val) )
{
BOOST_JSON_FAIL(ec, error::unknown_name);
return {system::in_place_error, ec};
Expand Down
8 changes: 8 additions & 0 deletions test/value_to.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,14 @@ class value_to_test
BOOST_TEST_THROWS_WITH_LOCATION(
value_to<::value_to_test_ns::E1>( value("x"), ctx... ));

{
// an embedded null must not truncate the enumerator name
value const jv( string_view("a\0", 2) );
BOOST_TEST( jv.as_string().size() == 2 );
BOOST_TEST_THROWS_WITH_LOCATION(
value_to<::value_to_test_ns::E1>( jv, ctx... ));
}

{
#ifndef BOOST_NO_CXX17_HDR_OPTIONAL
value jv = {{"n", -78}, {"d", 0.125}};
Expand Down
Loading