-
Notifications
You must be signed in to change notification settings - Fork 10
Auth registry for authenticated pull #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
243a2ed
registry: add authenticated registry backed by shared storage
HarshwardhanPatil07 822c787
dns, cloudinit: configure VMs to reach the authenticated registry
HarshwardhanPatil07 4b4f3ae
cli: wire authenticated registry into cluster lifecycle
HarshwardhanPatil07 7fed47b
test: add integration test for authenticated registry pull
HarshwardhanPatil07 9d321aa
ci: Build checkout images after restoring cache
HarshwardhanPatil07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| 10.88.0.2 registry registry.cluster.local | ||
| 10.88.0.3 auth-registry auth-registry.cluster.local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // SPDX-FileCopyrightText: 2026 The bink Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package cluster | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func TestStartCredentialFlagsDefaultToEmpty(t *testing.T) { | ||
| g := NewWithT(t) | ||
| cmd := newStartCmd() | ||
|
|
||
| username, err := cmd.Flags().GetString("registry-user") | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| password, err := cmd.Flags().GetString("registry-password") | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(username).To(BeEmpty()) | ||
| g.Expect(password).To(BeEmpty()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // SPDX-FileCopyrightText: 2026 The bink Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package registry | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func TestStartAuthFlagsRequireCredentials(t *testing.T) { | ||
| g := NewWithT(t) | ||
| cmd := newStartCmd() | ||
| cmd.SilenceErrors = true | ||
| cmd.SilenceUsage = true | ||
| cmd.SetArgs([]string{"--auth"}) | ||
|
|
||
| g.Expect(cmd.Execute()).To(MatchError("invalid auth registry credentials: registry username and password are required with --auth")) | ||
| } | ||
|
|
||
| func TestStartCredentialFlagsDefaultToEmpty(t *testing.T) { | ||
| g := NewWithT(t) | ||
| cmd := newStartCmd() | ||
|
|
||
| username, err := cmd.Flags().GetString("registry-user") | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| password, err := cmd.Flags().GetString("registry-password") | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(username).To(BeEmpty()) | ||
| g.Expect(password).To(BeEmpty()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.