Add year-based request chunking for YMD requests - #10
Closed
GianmarcoLattaruolo wants to merge 0 commit into
Closed
GianmarcoLattaruolo wants to merge 0 commit into
GianmarcoLattaruolo wants to merge 0 commit into
Conversation
GianmarcoLattaruolo
marked this pull request as draft
September 16, 2026 09:27
GianmarcoLattaruolo
force-pushed
the
add-year-chunking-for-request
branch
from
September 16, 2026 09:32
78f0c16 to
ab1b1d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_chunks: {year: N}on year-month-day requests, whereNis any positive integer.build_chunk_ymd_year_requests()and dispatch it frombuild_chunk_ymd_requests()when the time chunk key isyear.Test plan
tests/test_10_client_common.py(year chunks of size 1/2/3, leap years, remainder groups,year: 0rejected)tests/integration_test_10_cdsapi_era5_reanalysis.py(year: 1vs unchunked;year: 1andyear: 2selection)