Repository navigation
fix: invalid method call when changing the "update-date" preference - #4046
Merged
Merged
Conversation
Member
|
Hi, can u re-make this PR on top of main, please? Sorry for the trouble. |
ju1ius
force-pushed
the
ju1ius/fix-date-pref
branch
from
October 14, 2025 18:14
b3bef5c to
ba9b1a9
Compare
Member
|
Thanks, I am checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the preferences view, the handler for the
changed::update-datesignal called an unknown methodupdate_bottles(). This method appears to have been renamed toupdate_bottles_list(), so this might be an oversight during a refactor.Type of change
How Has This Been Tested?
By building and running the flatpak locally, toggling the "Show update date" preference on and off, and verifying that the update date is toggled correctly in the bottles list and that no
AttributeErroris raised.