Skip to content

fix: invalid method call when changing the "update-date" preference - #4046

Merged
mirkobrombin merged 1 commit into
bottlesdevs:mainfrom
ju1ius:ju1ius/fix-date-pref
Oct 23, 2025
Merged

mirkobrombin merged 1 commit into
bottlesdevs:mainfrom
ju1ius:ju1ius/fix-date-pref

Conversation

@ju1ius

@ju1ius ju1ius commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Description

In the preferences view, the handler for the changed::update-date signal called an unknown method update_bottles(). This method appears to have been renamed to update_bottles_list(), so this might be an oversight during a refactor.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

By building and running the flatpak locally, toggling the "Show update date" preference on and off, and verifying that the update date is toggled correctly in the bottles list and that no AttributeError is raised.

@mirkobrombin

Copy link
Copy Markdown
Member

Hi, can u re-make this PR on top of main, please? Sorry for the trouble.

@ju1ius
ju1ius force-pushed the ju1ius/fix-date-pref branch from b3bef5c to ba9b1a9 Compare October 14, 2025 18:14
@mirkobrombin

Copy link
Copy Markdown
Member

Thanks, I am checking

@mirkobrombin
mirkobrombin merged commit 6edfc00 into bottlesdevs:main Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants