Skip to content

Make subprocess calls Python 3.6 compatible - #4

Merged
bradthx merged 1 commit into
mainfrom
fix/python36-subprocess-compat
Apr 26, 2026
Merged

bradthx merged 1 commit into
mainfrom
fix/python36-subprocess-compat

Conversation

@bradthx

@bradthx bradthx commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Summary

  1. Replace subprocess.run capture_output and text arguments with Python 3.6-compatible stdout/stderr pipes and universal_newlines.
  2. Apply fix in file attribute probing and S3 upload paths.

Validation

  1. python3 -m py_compile ndrift tests/test_ndrift.py
  2. python3 -m unittest -q tests/test_ndrift.py

@bradthx
bradthx merged commit 773f16f into main Apr 26, 2026
4 checks passed
@bradthx
bradthx deleted the fix/python36-subprocess-compat branch April 26, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant