Repository navigation
Take vehicle_id first in send_location_to_vehicle - #243
Merged
Merged
Conversation
Every other method that takes a vehicle id takes it first, and this one hasn't been released yet, so match them now. Also list the lock and unlock exports in the parallax package docstring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup before releasing 2.4.0.
Changes
send_location_to_vehiclenow takesvehicle_idfirst:send_location_to_vehicle(vehicle_id, location). Every other method that takes a vehicle id takes it first (only the oldersend_vehicle_commandleads with the command). It was added in Add send_location_to_vehicle #230 and hasn't been released, so changing it now isn't a breaking change.rivian.parallaxdocstring lists theLOCK_RVM/encode_lock()andUNLOCK_RVM/encode_unlock()exports from Add signed Parallax lock/unlock commands #229, and its layout list is realigned.Testing
pytest(286 passed),ruff check,ruff format --checkandmypy src/rivianare clean.Note
bretterer/home-assistant-rivian#322 calls
send_location_to_vehicle(message, vehicle_id)and will need its arguments swapped when it bumps the client pin.🤖 Generated with Claude Code